P13-T2: Implement persistent broker daemon with single upstream Xcode bridge#64
Merged
SoundBlaster merged 9 commits intomainfrom Feb 16, 2026
Merged
P13-T2: Implement persistent broker daemon with single upstream Xcode bridge#64SoundBlaster merged 9 commits intomainfrom
SoundBlaster merged 9 commits intomainfrom
Conversation
…stream Xcode bridge
…ream Xcode bridge
…t, and graceful shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements
BrokerDaemoninsrc/mcpbridge_wrapper/broker/daemon.py, replacing the P13-T1 stub with a fully working persistent broker daemon that owns a singlexcrun mcpbridgeupstream subprocess.Key capabilities:
0s, 1s, 2s, … min(2^n, cap)s) when upstream crashesstatus()method returns{state, pid, upstream_pid}for health monitoringrun_forever()registers SIGTERM/SIGINT handlers and blocks until stoppedAlso updates
test_broker_stubs.pyto remove now-invalidNotImplementedErrorassertions from P13-T1.Type of Change
Quality Gates
make test- All tests pass with ≥90% coveragetests/unit/test_broker_daemon.pymake lint- No linting errors (ruff check src/clean)make format- N/A (ruff auto-fix applied during development)make typecheck- mypy not configured as hard gatemake doccheck- No docs/ changesDocumentation Sync
Testing
tests/unit/test_broker_daemon.py, 26 tests)pytest tests/unit/— 485 passed)xcrun mcpbridgedeferred to P13-T5Checklist
SPECS/ARCHIVE/_Historical/REVIEW_P13-T2_broker_daemon.md)Validation Report
SPECS/ARCHIVE/P13-T2_Implement_persistent_broker_daemon/P13-T2_Validation_Report.md— verdict: PASSFollow-up Tasks Added
FU-P13-T2-1(P3): Replacerun_forever()polling loop withasyncio.Event-based waitFU-P13-T2-2(P3): Move PID file write to after successful upstream launch